Fix cli command for device off #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1121 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 96 96
Lines 6110 6110
Branches 1506 1506
=======================================
Hits 5658 5658
Misses 354 354
Partials 98 98 ☔ View full report in Codecov by Sentry. |
rytilahti
approved these changes
Sep 20, 2024
|
Rather than do something specifically for this item I'm going to have a think about the CLI testing more generally to ensure we have good coverage and can more easily test across |
This was referenced Sep 27, 2024
Merged
sdb9696
added a commit
that referenced
this pull request
Sep 27, 2024
## [0.7.4](https://github.com/python-kasa/python-kasa/tree/0.7.4) (2024-09-27) [Full Changelog](0.7.3...0.7.4) **Release summary:** - KL135 color temp range corrected to 9000k max - Minor enhancements and project maintenance **Implemented enhancements:** - Add factory\_reset\(\) to iotdevice [\#1125](#1125) (@rytilahti) - Add reboot\(\) to the device interface [\#1124](#1124) (@rytilahti) - Add factory-reset command to cli [\#1108](#1108) (@rytilahti) **Fixed bugs:** - Extend KL135 ct range up to 9000K [\#1123](#1123) (@rytilahti) - Fix cli command for device off [\#1121](#1121) (@sdb9696) **Project maintenance:** - Use pytest-socket to ensure no tests are performing io [\#1133](#1133) (@sdb9696) - Enable ruff lint pycodestyle warnings [\#1132](#1132) (@sdb9696) - Add autouse fixture to patch asyncio.sleep [\#1131](#1131) (@sdb9696) - Mock asyncio.sleep for klapprotocol tests [\#1130](#1130) (@rytilahti) - Add fixture for T110 fw 1.9.0 [\#1129](#1129) (@rytilahti) - Speed up and simplify github workflows [\#1128](#1128) (@sdb9696) - Add KS200M\(US\) fw 1.0.12 fixture [\#1127](#1127) (@GatorEG) - Add stale PR/Issue github workflow [\#1126](#1126) (@sdb9696) - Add fixture for KL135\(US\) fw 1.0.15 [\#1122](#1122) (@rytilahti)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed it's missed when using the full
kasa device offcommand as opposed to the shortcut.