8000 Add missing typing_extensions dependency by sdb9696 · Pull Request #1101 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]

Skip to content

Add missing typing_extensions dependency #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

sdb9696
Copy link
Collaborator
@sdb9696 sdb9696 commented Aug 23, 2024

typing_extensions is a dependency of pydantic so it's getting installed by default but it should be an explicit dependency of python-kasa.

@sdb9696 sdb9696 added the maintenance Project improvements and maintenance label Aug 23, 2024
Copy link
codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (beb7ca2) to head (d030ede).
Report is 148 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1101   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          96       96           
  Lines        6073     6073           
  Branches     1496     1496           
=======================================
  Hits         5623     5623           
  Misses        351      351           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rytilahti
Copy link
Member

Why does it need to be an explicit dep? :)

@sdb9696
Copy link
Collaborator Author
sdb9696 commented Aug 23, 2024

Because we're importing it directly in our code. If we ever drop pydantic or pydantic drops typing_extensions we will break. Worse still we will break only when doing a pip install because it's also a mypy dependency so poetry install installs it as a dev dependency and the CI will pass.

@rytilahti
Copy link
Member

Ah, indeed. I'm wondering if we could use more lax versioning, but this is also fine!

Copy link
Member
@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@sdb9696 sdb9696 merged commit 2706e9a into master Aug 23, 2024
30 checks passed
@sdb9696 sdb9696 deleted the fix/typing_extensions branch August 23, 2024 18:23
@sdb9696
Copy link
Collaborator Author
sdb9696 commented Aug 23, 2024

Ah, indeed. I'm wondering if we could use more lax versioning, but this is also fine!

The version constraint is due to a python 3.13 bug resolved in the latest version. It matches HA's constraint so I figured it'd be ok in the wider world.

@sdb9696 sdb9696 added this to the 0.7.2 milestone Aug 30, 2024
@sdb9696 sdb9696 mentioned this pull request Aug 30, 2024
sdb9696 added a commit that referenced this pull request Aug 30, 2024
## [0.7.2](https://github.com/python-kasa/python-kasa/tree/0.7.2) (2024-08-30)

[Full Changelog](0.7.1...0.7.2)

**Release summary:**

- **Breaking** change to disable including the check for the latest firmware for tapo devices and newer kasa devices in the standard update cycle. To check for the latest firmware call `check_latest_firmware` on the firmware module or run the `check_latest_firmware` feature.
- Minor bugfixes and improvements.

**Breaking changes:**

- Disable automatic updating of latest firmware [\#1103](#1103) (@sdb9696)

**Implemented enhancements:**

- Improve performance of dict merge code [\#1097](#1097) (@bdraco)

**Fixed bugs:**

- Fix logging in iotdevice when a module is module not supported [\#1100](#1100) (@bdraco)

**Documentation updates:**

- Fix incorrect docs link in contributing.md [\#1099](#1099) (@sdb9696)

**Project maintenance:**

- Add flake8-pytest-style \(PT\) for ruff [\#1105](#1105) (@rytilahti)
- Add flake8-logging \(LOG\) and flake8-logging-format \(G\) for ruff [\#1104](#1104) (@rytilahti)
- Add missing typing\_extensions dependency [\#1101](#1101) (@sdb9696)
- Remove top level await xdoctest fixture [\#1098](#1098) (@sdb9696)
- Enable python 3.13, allow pre-releases for CI [\#1086](#1086) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project improvements and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0