Fix logging in iotdevice when a module is module not supported #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This debug logger was generating the `repr()` of each module and throwing it away because it had a % instead of a ,
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1100 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 96 96
Lines 6073 6073
Branches 1496 1496
=======================================
Hits 5623 5623
Misses 351 351
Partials 99 99 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Merged
sdb9696
added a commit
that referenced
this pull request
Aug 30, 2024
## [0.7.2](https://github.com/python-kasa/python-kasa/tree/0.7.2) (2024-08-30) [Full Changelog](0.7.1...0.7.2) **Release summary:** - **Breaking** change to disable including the check for the latest firmware for tapo devices and newer kasa devices in the standard update cycle. To check for the latest firmware call `check_latest_firmware` on the firmware module or run the `check_latest_firmware` feature. - Minor bugfixes and improvements. **Breaking changes:** - Disable automatic updating of latest firmware [\#1103](#1103) (@sdb9696) **Implemented enhancements:** - Improve performance of dict merge code [\#1097](#1097) (@bdraco) **Fixed bugs:** - Fix logging in iotdevice when a module is module not supported [\#1100](#1100) (@bdraco) **Documentation updates:** - Fix incorrect docs link in contributing.md [\#1099](#1099) (@sdb9696) **Project maintenance:** - Add flake8-pytest-style \(PT\) for ruff [\#1105](#1105) (@rytilahti) - Add flake8-logging \(LOG\) and flake8-logging-format \(G\) for ruff [\#1104](#1104) (@rytilahti) - Add missing typing\_extensions dependency [\#1101](#1101) (@sdb9696) - Remove top level await xdoctest fixture [\#1098](#1098) (@sdb9696) - Enable python 3.13, allow pre-releases for CI [\#1086](#1086) (@rytilahti)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This debug logger was generating the
repr()of each module and throwing it away because it had a%instead of a,