8000 pytype_test.py: Fix typechecking errors following #9747 by Avasam · Pull Request #9849 · python/typeshed · GitHub
[go: up one dir, main page]

Skip to content
8000

pytype_test.py: Fix typechecking errors following #9747 #9849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Avasam
Copy link
Collaborator
@Avasam Avasam commented Mar 6, 2023

Follow up to #9747

Superseeds #9847 (comment) ( Closes #9847 ) by fixing the potentially None type error in a more principled way. The code already implicitly made this assert assumption.

CC. @AlexWaygood

Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, thank you!

Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, thank you!

@AlexWaygood AlexWaygood merged commit 14b06ae into python:main Mar 6, 2023
@Avasam Avasam deleted the pytype_test.py--Fix-typechecking-errors branch March 6, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0