pytype_test.py: Fix typechecking errors
#9847
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh, I thought this was supposed to be fixed by #9747, not produce different errors 🤔(that was kindof the whole point of that PR) |
Avasam
reviewed
Mar 6, 2023
Comment on lines
+164
to
+165
| pkg_resources.get_distribution(pkg).egg_info, # type: ignore[arg-type] # pyright: ignore[reportGeneralTypeIssues] | ||
| "top_level.txt", # pyright: ignore[reportGeneralTypeIssues] |
There was a problem hiding this comment.
Ah, right, because Distribution.egg_info can be None.
Something like this? The code already implicitly made this assert assumption.
Suggested change
| pkg_resources.get_distribution(pkg).egg_info, # type: ignore[arg-type] # pyright: ignore[reportGeneralTypeIssues] | |
| "top_level.txt", # pyright: ignore[reportGeneralTypeIssues] | |
| egg_info = pkg_resources.get_distribution(pkg).egg_info | |
| assert isinstance(egg_info, str) | |
| # See https://stackoverflow.com/a/54853084 | |
| top_level_file = os.path.join(egg_info, "top_level.txt") |
There was a problem hiding this comment.
Wanna make another PR? I'll happily close this one if you can get the CI green in a more principled way 😀
There was a problem hiding this comment.
There: #9849 (comment) Feel free to suggest changes if you want a different assert (truthy, is not None, ...) or a message with said assert "Missing egg_info on package ..."
|
Closing in favour of #9849 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type checkers have changed their minds about why they don't like this snippet of code, following the new release of
types-setuptools, following #9747(Failing CI run here: https://github.com/python/typeshed/actions/runs/4346178794)
Cc. @Avasam