8000 ci: Do not run stubtest_third_party for deleted stubs by Akuli · Pull Request #6467 · python/typeshed · GitHub
[go: up one dir, main page]

Skip to content

ci: Do not run stubtest_third_party for deleted stubs #6467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

Akuli
Copy link
Collaborator
@Akuli Akuli commented Dec 1, 2021

@Akuli
Copy link
Collaborator Author
Akuli commented Dec 1, 2021

Instead of merging this directly, it might be better to temporarily include this in #6465 to make sure it works. Once CI passes on #6465, we can merge this to master (and then master to #6465, but that's optional).

@srittau
Copy link
Collaborator
srittau commented Dec 1, 2021

A quick local check confirms that this should work correctly. I'll just merge and then we'll see what happens.

@srittau srittau merged commit 50d29ef into python:master Dec 1, 2021
@srittau
Copy link
Collaborator
srittau commented Dec 1, 2021

And my local test was wrong, it seems. Oh well, I'm trying to fix the remaining issue in #6465.

@Akuli
Copy link
Collaborator Author
Akuli commented Dec 1, 2021

GitHub Actions runs bash with more checking for errors than what is useful for interactive use. I knew this might be a problem, and indeed it was :D

@Akuli Akuli deleted the stubtest-ci-fix branch December 1, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0