8000 Fix issues with third-party stub tests by srittau · Pull Request #6466 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Fix issues with third-party stub tests #6466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix issues with third-party stub tests #6466

wants to merge 2 commits into from

Conversation

srittau
Copy link
Collaborator
@srittau srittau commented Dec 1, 2021
  • Only test each distribution once.
  • Run stubtest separately for each distribution.
  • Skip stubtest for removed distributions.

@srittau srittau mentioned this pull request Dec 1, 2021
Merged
@Akuli
Copy link
Collaborator
Akuli commented Dec 1, 2021

#6467 is my attempt at fixing this, which is a bit hackier but tests all stubs at once. I guess it makes sense to test them separately rather than calling stubtest_third_party.py with multiple stubs at once, since a pull request usually only changes one third-party stub.

@srittau
Copy link
Collaborator Author
srittau commented Dec 1, 2021

#6467

@srittau srittau closed this Dec 1, 2021
@srittau srittau deleted the stubtest-3rd-removal branch December 1, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srittau @Akuli
0