Makes `psutil.Popen` an alias of `subprocess.Popen` #6078

sobolevn · 2021-09-26T15:10:01Z

srittau

I'm not sure what this change is trying to accomplish. Popen is not an alias at runtime. In fact, it has a different class hierarchy, deriving from psutil.Process, which is a property that should be kept in the stubs.

sobolevn · 2021-09-27T08:05:43Z

@srittau see #6074 (comment)

sobolevn · 2021-09-27T08:19:06Z

Yes, this Popen is much more than subprocess.Popen, because it has an access to psutils.Process methods and attributes: https://github.com/giampaolo/psutil/blob/master/psutil/__init__.py#L1342

This is not going to work 😞

Makes psutil.Popen an alias of subprocess.Popen

3bb29e2

Refs #6074

sobolevn mentioned this pull request Sep 26, 2021

Improves Popen types in psutil #6074

Merged

srittau reviewed Sep 27, 2021

View reviewed changes

sobolevn closed this Sep 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Makes `psutil.Popen` an alias of `subprocess.Popen` #6078

Makes `psutil.Popen` an alias of `subprocess.Popen` #6078

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Makes psutil.Popen an alias of subprocess.Popen #6078

Makes psutil.Popen an alias of subprocess.Popen #6078

Uh oh!

Conversation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Makes `psutil.Popen` an alias of `subprocess.Popen` #6078

Makes `psutil.Popen` an alias of `subprocess.Popen` #6078