8000 Makes `psutil.Popen` an alias of `subprocess.Popen` by sobolevn · Pull Request #6078 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Makes psutil.Popen an alias of subprocess.Popen #6078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Makes psutil.Popen an alias of subprocess.Popen #6078

wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

Refs #6074

@sobolevn sobolevn mentioned this pull request Sep 26, 2021
Merged
srittau
srittau reviewed Sep 27, 2021
View reviewed changes
Copy link
Collaborator
@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this change is trying to accomplish. Popen is not an alias at runtime. In fact, it has a different class hierarchy, deriving from psutil.Process, which is a property that should be kept in the stubs.

@sobolevn
Copy link
Member Author

@srittau see #6074 (comment)

@sobolevn
Copy link
Member Author

Yes, this Popen is much more than subprocess.Popen, because it has an access to psutils.Process methods and attributes: https://github.com/giampaolo/psutil/blob/master/psutil/__init__.py#L1342

This is not going to work 😞

@sobolevn sobolevn closed this Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @srittau
0