8000 Improves `Popen` types in `psutil` by sobolevn · Pull Request #6074 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Improves Popen types in psutil #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2021
Merged

Improves Popen types in psutil #6074

merged 2 commits into from
Sep 25, 2021

Conversation

sobolevn
Copy link
Member
  1. __dir__ was removed, because it has regular return type from object
  2. Popen.wait has the same type as Process.wait

@hauntsaninja hauntsaninja merged commit a9227ed into python:master Sep 25, 2021
srittau
srittau reviewed Sep 26, 2021
View reviewed changes
@Akuli
Copy link
Collaborator
Akuli commented Sep 26, 2021

Perhaps we should just alias this to subprocess.Popen? It appears to be basically subprocess.Popen with a bug fix, and for typing purposes there shouldn't be any difference.

@sobolevn sobolevn mentioned this pull request Sep 26, 2021
Closed
@sobolevn
Copy link
Member Author

@Akuli great idea. I've opened a PR based on your suggestion #6078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @Akuli @srittau @hauntsaninja
0