8000 Use ‘exclude list’ instead of ‘blacklist’ by wbolster · Pull Request #4297 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Use ‘exclude list’ instead of ‘blacklist’ #4297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2020
Merged

Use ‘exclude list’ instead of ‘blacklist’ #4297

merged 1 commit into from
Jul 1, 2020

Conversation

wbolster
Copy link
Contributor

This replaces all uses of ‘blacklist’ with ‘exclude list’. Benefits:

  • It is racially neutral terminology; see e.g. [1]

  • It makes the meaning more clear. In fact, with the popular Python
    autoformatter called ‘black’, also used by this project, files can be
    ‘blackened’ which is something completely different from them being on
    a blacklist.

[1] https://chromium.googlesource.com/chromium/src/+/master/styleguide/inclusive_code.md#racially-neutral

@wbolster
Use ‘exclude list’ instead of ‘blacklist’
2a6753e 
This replaces all uses of ‘blacklist’ with ‘exclude list’. Benefits:

- It is racially neutral terminology; see e.g. [1]

- It makes the meaning more clear. In fact, with the popular Python
  autoformatter called ‘black’, also used by this project, files can be
  ‘blackened’ which is something completely different from them being on
  a blacklist.

[1] https://chromium.googlesource.com/chromium/src/+/master/styleguide/inclusive_code.md#racially-neutral
srittau
srittau approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator
@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections.

@wbolster
Copy link
Contributor Author

don't merge yet; i'll push another commit to this branch to do the same for ‘whitelist’ -> ‘include list’ for consistency.

@wbolster
Copy link
Contributor Author

wait, scratch that. all usages of ‘whitelist’ in this code base:

  1. refer to urllib3 API, or
  2. refer to mypy.stubtest API and command line flags, and to typeshed code that is directly preparing arguments to pass to mypy.stubtest

changing item 1 would be incorrect.

changing item 2 does not make sense, since it would be a half-baked typeshed-only rename, which would only add confusion.

so, on second thought: pull request is just fine as it stands. :)

@srittau srittau merged commit 3efb675 into python:master Jul 1, 2020
@wbolster wbolster deleted the avoid-blacklist-terminology branch July 1, 2020 08:16
@gpshead gpshead mentioned this pull request Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbolster @srittau
0