8000 Drop all use of the name whitelist in the codebase · Issue #4436 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Drop all use of the name whitelist in the codebase #4436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gpshead opened this issue Aug 11, 2020 · 3 comments · Fixed by #5614
Closed

Drop all use of the name whitelist in the codebase #4436

gpshead opened this issue Aug 11, 2020 · 3 comments · Fixed by #5614

Comments

@gpshead
Copy link
Member
gpshead commented Aug 11, 2020

#4297 changed blacklist to exclude_list in the typeshed codebase. 👍

But whitelist remains. Please rename all whitelist references to allow_list or similar.
@gpshead
Copy link
Member Author
gpshead commented Aug 11, 2020

in particular scripts/update-stubtest-whitelist.py and tests/stubtest_whitelist (I didn't grep, just poked around the tree)

hauntsaninja pushed a commit to hauntsaninja/mypy that referenced this issue Sep 6, 2020
stubtest: use allowlist instead of whitelist
744e2b2 
Allows use of the old options to preserve backwards compatibility
A step towards python/typeshed#4436
@hauntsaninja hauntsaninja mentioned this issue Sep 6, 2020
Merged
hauntsaninja pushed a commit to hauntsaninja/mypy that referenced this issue Sep 6, 2020
stubtest: use allowlist instead of whitelist
f930139 
Allows use of the old options to preserve backwards compatibility
A step towards python/typeshed#4436
hauntsaninja added a commit to python/mypy that referenced this issue Sep 7, 2020
@hauntsaninja
stubtest: use allowlist instead of whitelist (#9426)
e959952 
Allows use of the old options to preserve backwards compatibility
A step towards python/typeshed#4436

Co-authored-by: hauntsaninja <>
@Nikhil1O1
Copy link

Does this still require improvements? If yes then I'm in else why don't you mark it closed
@gpshead

@hauntsaninja
Copy link
Collaborator
hauntsaninja commented Oct 6, 2020 •
edited
Loading

It's blocked on changes^ to mypy, which have been made but need to be released before it makes sense to change typeshed

hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this issue Jun 10, 2021
Rename whitelist to allowlist
2bbd731 
Resolves python#4436

I want to add stubtest for third party stubs, and figured it'd be easier
to make this change now.
@hauntsaninja hauntsaninja mentioned this is 744A sue Jun 10, 2021
Merged
hauntsaninja added a commit that referenced this issue Jun 10, 2021
@hauntsaninja
Rename whitelist to allowlist (#5614)
e66cece 
Resolves #4436

I want to add stubtest for third party stubs, and figured it'd be easier
to make this change now.

Co-authored-by: hauntsaninja <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename whitelist to allowlist hauntsaninja/typeshed
3 participants
@gpshead @hauntsaninja @Nikhil1O1
0