10000 Stop using django.contrib.comments and django_comments_xtd by berkerpeksag · Pull Request #981 · python/pythondotorg · GitHub
[go: up one dir, main page]
Skip to content

Stop using django.contrib.comments and django_comments_xtd #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 6, 2017
Merged

Stop using django.contrib.comments and django_comments_xtd #981

merged 14 commits into from
Aug 6, 2017

Conversation

berkerpeksag
Copy link
Member
@berkerpeksag berkerpeksag commented Aug 5, 2016 •
edited
Loading

Refs #591

@malemburg I didn't remove django_comments_xtd completely. Job posters and reviewers can still see old comments, but I'm planning to remove the whole app after a deprecation period.

I've also fixed some small bugs in email templates.

TODOs

  • Add more tests

@berkerpeksag berkerpeksag changed the title Stop using django.contrib.comments and django_comments_xtd [WIP] Stop using django.contrib.comments and django_comments_xtd Aug 5, 2016
@berkerpeksag berkerpeksag changed the title [WIP] Stop using django.contrib.comments and django_comments_xtd Stop using django.contrib.comments and django_comments_xtd Aug 5, 2017
@berkerpeksag
Copy link
Member Author
berkerpeksag commented Aug 5, 2017 •
edited
Loading

Ok, I think this is finally ready to go. Here's a summary of this PR:

  • Made django_comments_xtd read-only. I'm going to open another issue to migrate old comments into jobs.JobReviewComment.
  • Wrote a lot of tests to make sure that I didn't break anything. Numbers of the most important files of the jobs app: 
    jobs/forms.py                                         38      0      4      0   100%
jobs/managers.py                                      39      2      0      0    95%
jobs/models.py                                       131      5     18      6    93%
jobs/views.py                                        218      6     32      4    95%
  • Fixed a lot of issues regarding to email templates. See the commits for details.
  • Deleted unnecessary code and simplified get_queryset() and get_object() logic in jobs/views.py.
  • Made several UX improvements. See the commits for details.

@berkerpeksag berkerpeksag merged commit 538d40c into python:master Aug 6, 2017
@berkerpeksag berkerpeksag deleted the 591-django-comments branch August 6, 2017 11:49
@berkerpeksag berkerpeksag mentioned this pull request Aug 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@berkerpeksag
0