8000 Stop using django.contrib.comments · Issue #591 · python/pythondotorg · GitHub
[go: up one dir, main page]
Skip to content

Stop using django.contrib.comments #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ubernostrum opened this issue Feb 27, 2015 · 3 comments
Closed

Stop using django.contrib.comments #591

ubernostrum opened this issue Feb 27, 2015 · 3 comments
Labels
app/jobs Relates to the jobs app

Comments

@ubernostrum
Copy link
Contributor

First off, django.contrib.comments is being unbundled from Django and removed in Django 1.8 (and already raises deprecation warnings in Django 1.7). Second, it's overkill for what we're using it for.

Instead, replace it with a simpler model that can live in the jobs app and store the basic information it needs (sender and message, associated with a particular job posting) and use that to handle comments back and forth about job postings.
@ubernostrum
Copy link
Contributor Author

A quick thought:

The basic idea here is that a comment posted on a job will be sent to the set:

(jobs moderators + job submitter) - (commenter)

But I don't actually know how we distinguish who will have the ability to see, respond to and post moderator-type comments on job submissions waiting for approval. Is there a Group instance somewhere for that? Should we create one and specify it in settings?

@frankwiles
Copy link
Member

Yes there is a 'Job Board Admin' group, see https://github.com/python/pythondotorg/blob/master/jobs/views.py#L12-L13

@ubernostrum ubernostrum mentioned this issue Mar 6, 2015
Closed
@ubernostrum ubernostrum self-assigned this Mar 6, 2015
This was referenced Mar 6, 2015
Closed
Closed
Closed
Closed
Closed
@ubernostrum ubernostrum added the app/jobs Relates to the jobs app label Mar 7, 2015
@berkerpeksag berkerpeksag mentioned this issue Mar 15, 2015
Closed
@berkerpeksag berkerpeksag mentioned this issue Oct 2, 2015
Closed
@berkerpeksag berkerpeksag mentioned this issue Aug 5, 2016
Merged
1 task
berkerpeksag added a commit that referenced this issue Aug 6, 2017
@berkerpeksag
Stop using django.contrib.comments and django_comments_xtd
44921b9 
Refs #591
@berkerpeksag berkerpeksag changed the title Jobs board: stop using django.contrib.comments Stop using django.contrib.comments Aug 6, 2017
@berkerpeksag
Copy link
Member
berkerpeksag commented Aug 6, 2017 •
edited
Loading

Current status:

@berkerpeksag berkerpeksag mentioned this issue Aug 10, 2017
Merged
berkerpeksag added a commit that referenced this issue Aug 10, 2017
@berkerpeksag
Remove django_comments_xtd dependency
978d48c 
Refs #591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/jobs Relates to the jobs app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ubernostrum @berkerpeksag @frankwiles
0