10000 fix: links are direct to asset by JacobCoffee · Pull Request #2593 · python/pythondotorg · GitHub
[go: up one dir, main page]
Skip to content

fix: links are direct to asset #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 8, 2024
Merged

fix: links are direct to asset #2593

merged 8 commits into from
Oct 8, 2024

Conversation

JacobCoffee
Copy link
Member

Description

  • Fixes asset links on sponsor user page

Closes

funny

  • code change: 30 minutes
  • tests: 1.5 hours

@JacobCoffee JacobCoffee changed the title fix: links are direct to assett fix: links are direct to asset Sep 19, 2024
@JacobCoffee JacobCoffee enabled auto-merge (squash) September 20, 2024 17:50
ewdurbin
ewdurbin reviewed Sep 23, 2024
View reviewed changes
@JacobCoffee
Copy link
Member Author

Changes in e53f422

Although I am not 100%, my checks into the various user views for the removal ofwith-right-sidebar have shown that everything just fills the empty space instead of wasting it. Have yet to find a page that uses it but I will continue to check.

How it looks ish (latest changes I removed excessive padding as you can see in image 1 but further images have it in screenshot.. has since been fixed)

Details image image image image

JacobCoffee
JacobCoffee commented Sep 26, 2024
View reviewed changes
ewdurbin
ewdurbin reviewed Sep 26, 2024
View reviewed changes
@JacobCoffee JacobCoffee mentioned this pull request Oct 8, 2024
Open
@JacobCoffee
Copy link
Member Author
JacobCoffee commented Oct 8, 2024 •
edited
Loading

@loren-c requested a more neutral benefits view instead of the green checks, and also asked if we could include the category.

image image

45d654f

@loren-c
Copy link
Contributor
loren-c commented Oct 8, 2024

the new version looks great to me!

@JacobCoffee
Copy link
Member Author

ready for review then, @ewdurbin :)

ewdurbin
ewdurbin approved these changes Oct 8, 2024
View reviewed changes
templates/users/base.html
@@ -10,7 +10,8 @@
{% endblock %}


{% block content_attributes %}with-right-sidebar{% endblock %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to remove this rather than comment it.

@JacobCoffee JacobCoffee merged commit 3ad7b96 into main Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loren-c loren-c loren-c left review comments

@ewdurbin ewdurbin ewdurbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: View provided assets button takes you to the full assets list
3 participants
@JacobCoffee @loren-c @ewdurbin
0