10000 fix: links are direct to asset by JacobCoffee · Pull Request #2593 · python/pythondotorg · GitHub
[go: up one dir, main page]
Skip to content

fix: links are direct to asset #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 8, 2024
Merged

fix: links are direct to asset #2593

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
356af6a
fix: links are direct to assett
JacobCoffee Sep 19, 2024
6880215
test: add them
JacobCoffee Sep 19, 2024
f827510
chore: remove unused imports
JacobCoffee Sep 19, 2024
50cd7ce
style: bring asset view data into sponsorship overview, reorganize page
JacobCoffee Sep 26, 2024
ba7bd02
style: revert css manual changes
JacobCoffee Sep 26, 2024
2ed726d
style: run sass compiler
JacobCoffee Sep 26, 2024
0eec197
tests: fix test for asset file link
JacobCoffee Sep 26, 2024
45d654f
style: add category, change layout
JacobCoffee Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests: fix test for asset file link
  • Loading branch information
@JacobCoffee
JacobCoffee committed Oct 8, 2024
commit 0eec19764513a1dd495d6a09085f978ad742d6a2
2 changes: 1 addition & 1 deletion users/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ def test_asset_links_are_direct(self) -> None:
expected_asset_link = f'href="{asset.value.url}"'

# and finally check that the asset link is ACTUALLY pointing to the asset and not the list view page
self.assertIn("View asset", content, "View asset text not found.")
self.assertIn("View File", content, "View file text not found.")
self.assertIn(expected_asset_link, content, "Asset link not found in the page.")
self.assertEqual(response.status_code, 200)
self.assertTemplateUsed(response, "users/sponsorship_detail.html")
Expand Down
0