8000 Remove django_comments_xtd dependency by berkerpeksag · Pull Request #1121 · python/pythondotorg · GitHub
[go: up one dir, main page]

Skip to content

Remove django_comments_xtd dependency #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove django_comments_xtd dependency
Refs #591
  • Loading branch information
berkerpeksag committed Aug 10, 2017
commit cca271a208c89decff5bfcb928921a3f097843a6
3 changes: 0 additions & 3 deletions base-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ django-timedeltafield==0.7.3
requests==2.5.1

django-jsonfield==0.9.13
git+https://github.com/berkerpeksag/django-contrib-comments.git@pydotorg
django-comments-xtd==1.5.1

django-honeypot==0.4.0
django-markupfield==1.3.2

Expand Down
7 changes: 0 additions & 7 deletions pydotorg/settings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,6 @@
'django.contrib.admin',
'django.contrib.admindocs',

'django_comments',
'django_comments_xtd',
'jsonfield',
'pipeline',
'sitetree',
Expand Down Expand Up @@ -206,11 +204,6 @@
### Development
DEV_FIXTURE_URL = 'https://www.python.org/m/fixtures/dev-fixtures.json.gz'

### Comments

COMMENTS_APP = 'django_comments_xtd'
COMMENTS_XTD_MAX_THREAD_LEVEL = 0

### Honeypot
HONEYPOT_FIELD_NAME = 'email_body_text'
HONEYPOT_VALUE = 'write your message'
Expand Down
28 changes: 0 additions & 28 deletions templates/comments/form.html

This file was deleted.

17 changes: 0 additions & 17 deletions templates/comments/posted.html

This file was deleted.

36 changes: 0 additions & 36 deletions templates/comments/preview.html

This file was deleted.

2 changes: 0 additions & 2 deletions templates/jobs/job_detail.html
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,7 @@ <h2>Contact Info</h2>
{% if jobs_board_admin or user_can_edit %}
<hr>
<h1>Comments are only viewable between the submitter and job reviewers.</h1>
{% load comments %}
<h2>Job Review Discussion</h2>
{% render_comment_list for object %}
<dl id="comments">
{% for comment in object.review_comments.all %}
<dt>
Expand Down
0