-
-
Notifications
You must be signed in to change notification settings - Fork 214
Translate library/string #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
我覺得 ok 不過 library/string.po 我們上次 meetup 也在翻譯,目前看起來好像部分有跟其他 PR 有重複,我會優先 review 先前的 PR |
好的沒有問題,抱歉沒注意到。那我再去找其他的來翻譯🙂 |
@tso1158687 |
b680bec
to
9b36ded
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good enough to be merged, only two minor issues
@tso1158687 這部分已經處理完 (#731),再麻煩你有空的時候幫忙修正 & resolve conflicts |
@tso1158687 如果你目前沒辦法處理的話我就來接手修正囉? |
不好意思我沒有注意到訊息,我馬上來修正一下 |
9b36ded
to
976d830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
只剩一個小問題,我就直接 commit 了,感謝 🙏🏽
Translate
ASCII characters 這個詞我有點糾結要翻譯成什麼,最後選擇ASCII 字元,可以看看這樣的說法是否恰當,或是說有更好的建議!