8000 trans: how venv work by hsiangjenli · Pull Request #609 · python/python-docs-zh-tw · GitHub
[go: up one dir, main page]

Skip to content

trans: how venv work #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Aug 27, 2023
Merged

Conversation

hsiangjenli
Copy link
Contributor

No description provided.

Copy link
Collaborator
@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 阿紝!

請你先修正以下幾個地方,等改完後我會針對語句流暢性再仔細看一遍 🙏🏽

library/venv.po Outdated

#: ../../library/venv.rst:93
msgid ""
"You don't specifically *need* to activate a virtual environment, as you can "
"just specify the full path to that environment's Python interpreter when "
"invoking Python. Furthermore, all scripts installed in the environment "
"should be runnable without activating it."
msgstr ""
msgstr "你不用特別開啟虛擬環境,你可以直接在調用 Python 直譯器時指定該環境的完整路徑。此外,所有安裝在環境裡的腳本都應該都可以在未啟用虛擬環境的情況下運行。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你的譯文有單行過長的問題,雖然不影響 doc build 結果,但建議還是做一下 formatting 讓 po 檔的可讀性更高。
可以使用 powrap 這項工具:

pip install powrap
powrap library/venv.po

@hsiangjenli hsiangjenli requested a review from mattwang44 August 22, 2023 14:03
@mattwang44
Copy link
Collaborator

@hsiangjenli 大部分 review comment 都還沒修掉歐,請繼續修正 🙏🏽

@hsiangjenli
Copy link
Contributor Author
hsiangjenli commented Aug 22, 2023

@mattwang44 抱歉抱歉,我第一次使用 pull request 還不是很熟悉,請問我是不是不能直接在上面修改然後 commit?我是像下面那張圖用 suggestion 修改,但是他好像不能由我直接 commit。還是我重新拉一個 pull request?

image

@hsiangjenli
Copy link
Contributor Author

@mattwang44 這樣應該有改到了吧!!! 再麻煩了!!!

@mattwang44
Copy link
Collaborator

hmmm
你現在用的 suggestion 通常是給 reviewer (我) 用的,讓 author (你) 可以決定是否採納,但 reviewer 不一定會用 suggestion。
你都用 suggestion 也不是不行,只是 PR 頁面上就多了很多不是很有用處的 comments 紀錄,比較好的方式還是在你 local 上根據 review comment 修正後再 push 上新的 commit(s) 會比較乾淨一些。

不過沒關係,還有很多練習機會XD

@mattwang44
Copy link
Collaborator
mattwang44 commented Aug 22, 2023

你的譯文有單行過長的問題,雖然不影響 doc build 結果,但建議還是做一下 formatting 讓 po 檔的可讀性更高。 可以使用 powrap 這項工具:

pip install powrap
powrap library/venv.po

再請你從 local 下指令修正這個問題後再推上來

library/venv.po Outdated
Comment on lines 337 to 339
"為了實現這一點,安裝在虛擬環境中的腳本會有一個 ``#!`` 列,此列指向該環境的 Python 直譯器,例如: :samp:`#!/{<path-to-venv>}/bin/python`。"
"這代表無論 :envvar:`!PATH` 的值為何,該腳本都會在直譯器上運行"
"在 Windows 上,如果你安裝了 :ref:`launcher`,則支援 ``#!`` 行處理。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原文的 \"shebang\" 都被改成了 ``#!``

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是,還是使用 shebang 比較合適?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我覺得還是盡量忠實呈現原文比較好

@hsiangjenli
Copy link
Contributor Author

@mattwang44 拍謝,我真的很不熟,麻煩你了!!感謝感謝🙏🙏🙏

@mattwang44 mattwang44 self-requested a review August 24, 2023 03:08
@mattwang44 mattwang44 force-pushed the trans/how_venv_work branch from 978a1de to ceeb386 Compare August 27, 2023 18:00
@mattwang44 mattwang44 force-pushed the trans/how_venv_work branch from eebe32f to 819c9a6 Compare August 27, 2023 18:24
Copy link
Collaborator
@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
我有小修幾個地方,是因為原文有更新所以翻譯要跟著更正

@mattwang44 mattwang44 merged commit b6af7d9 into python:3.12 Aug 27, 2023
@hsiangjenli hsiangjenli deleted the trans/how_venv_work branch August 28, 2023 02:48
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
* trans: venv

* feat: trans venv

* feat: trans venv

* Update library/venv.po

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>

* Update library/venv.po

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>

* Update library/venv.po

* Update library/venv.po

* Update library/venv.po

* Update library/venv.po

* Update library/venv.po

* Update library/venv.po

* Update library/venv.po

* Update library/venv.po

* Update library/venv.po

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>

* Update library/venv.po

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>

* trans: format

* fix: ``#!`` to \"shebang\"

* fix: 修正語句、標點符號

* fix: 修正語句

* chore(library/venv): format with powrap

* fix(library/venv): fix incorrect translation

---------

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0