8000 Fuzzies in library/xml.dom.po by Seluj78 · Pull Request #1002 · python/python-docs-fr · GitHub
[go: up one dir, main page]
Skip to content

Fuzzies in library/xml.dom.po #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2020
Merged

Fuzzies in library/xml.dom.po #1002

merged 5 commits into from
May 6, 2020

Conversation

Seluj78
Copy link
Collaborator
@Seluj78 Seluj78 commented Nov 17, 2019

No description provided.

@Seluj78 Seluj78 added the NEED REVIEWER This PR needs a reviewer :) label Nov 17, 2019
@Seluj78 Seluj78 self-assigned this Nov 17, 2019
vpoulailleau
vpoulailleau suggested changes Nov 18, 2019
View reviewed changes
Copy link
Contributor
@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et encore padpo ! 😉

awecx
awecx suggested changes Nov 20, 2019
View reviewed changes
Copy link
@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sed "s/Renvoi/Renvoie/g".
Sinon c'est bon.

deronnax
8000 deronnax requested changes Nov 20, 2019
View reviewed changes
christopheNan
christopheNan suggested changes Nov 20, 2019
View reviewed changes
Copy link
Contributor
@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci.
Je pense que le fichier en entier mériterait une revue par Grammalecte.

@vpoulailleau
Copy link
Contributor

Merci.
Je pense que le fichier en entier mériterait une revue par Grammalecte.

@christopheNan :

padpo -i library/xml.dom.po

Effectivement, y a du boulot. Par contre sur cette PR, padpo est content dans l'ensemble.

@Seluj78 @christopheNan
Apply suggestions from code review
6e83412 
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
christopheNan
christopheNan reviewed Nov 24, 2019
View reviewed changes
vpoulailleau
vpoulailleau suggested changes Nov 25, 2019
View reviewed changes
Copy link
Contributor
@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le padpo du matin 😉

@awecx awecx added awaiting changes and removed NEED REVIEWER This PR needs a reviewer :) labels Dec 11, 2019
deronnax and others added 3 commits May 5, 2020 09:47
@deronnax @christopheNan @vpoulailleau
Apply suggestions from code review
ecba481 
Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Co-authored-by: Vincent Poulailleau <vpoulailleau@gmail.com>
@deronnax
wrapping
ed7e9aa
@deronnax
correction espaces
eb9c73f
@deronnax deronnax requested a review from awecx May 5, 2020 22:14
@deronnax
Copy link
Collaborator
deronnax commented May 5, 2020

Je pense que le fichier en entier mériterait une revue par Grammalecte.

XML c'est une technologie déjà pas terrible en totale perte de vitesse, surtout dans l'écosystème python, on va garder ça pour (beaucoup) plus tard, hein 😃

@deronnax deronnax merged commit 3346346 into python:3.8 May 6, 2020
@Seluj78 Seluj78 deleted the fuzzies-library-xml-dom branch February 15, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpoulailleau vpoulailleau vpoulailleau requested changes

@deronnax deronnax deronnax approved these changes

@christopheNan christopheNan christopheNan approved these changes

@awecx awecx awecx approved these changes

Assignees

@Seluj78 Seluj78

@awecx awecx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Seluj78 @vpoulailleau @deronnax @christopheNan @awecx
0