10000 Meta: Add a note about populating the PR from a template. by freakboy3742 · Pull Request #3474 · python/peps · GitHub
[go: up one dir, main page]
Skip to content

Meta: Add a note about populating the PR from a template. #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 12, 2023
Merged

Meta: Add a note about populating the PR from a template. #3474

merged 5 commits into from
Oct 12, 2023

Conversation

freakboy3742
Copy link
Contributor
@freakboy3742 freakboy3742 commented Oct 10, 2023 •
edited by github-actions bot
Loading

In the process of submitting PEP730, I was confused about the process of populating the PEP from a template. This PR adds a note to the contribution guide so others don't hit the same problem.

📚 Documentation preview 📚: https://pep-previews--3474.org.readthedocs.build/

@freakboy3742 freakboy3742 requested a review from a team as a code owner October 10, 2023 15:08
JelleZijlstra
JelleZijlstra reviewed Oct 10, 2023
View reviewed changes
AA-Turner
AA-Turner reviewed Oct 10, 2023
View reviewed changes
hugovk
hugovk reviewed Oct 11, 2023
View reviewed changes
freakboy3742 and others added 2 commits October 11, 2023 10:44
@freakboy3742 @hugovk
Apply suggestions from code review
6d2a364 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@freakboy3742
Merge branch 'main' into pep-pr-creation
5515d83
hugovk
hugovk approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk added the meta Related to the repo itself and its processes label Oct 12, 2023
@hugovk hugovk merged commit 6c817a6 into python:main Oct 12, 2023
@hugovk hugovk mentioned this pull request Oct 12, 2023
Closed
25 tasks
@encukou
Copy link
Member
encukou commented Oct 12, 2023

FWIW, I I do use the link that these instructions boldly discourage, and I copy the template from the file in .github/PULL_REQUEST_TEMPLATES. It's useful to see the checklist as I work on the changes.

But probably not useful enough to complicate the instructions.

@freakboy3742 freakboy3742 deleted the pep-pr-creation branch October 12, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@AA-Turner AA-Turner AA-Turner left review comments

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
meta Related to the repo itself and its processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@freakboy3742 @encukou @JelleZijlstra @hugovk @AA-Turner
0