8000 PEP 730: Adding iOS as a supported platform by freakboy3742 · Pull Request #3473 · python/peps · GitHub
[go: up one dir, main page]
Skip to content

PEP 730: Adding iOS as a supported platform #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 11, 2023
Merged

PEP 730: Adding iOS as a supported platform #3473

merged 11 commits into from
Oct 11, 2023

Conversation

freakboy3742
Copy link
Contributor
@freakboy3742 freakboy3742 commented Oct 10, 2023 •
edited by hugovk
Loading

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--3473.org.readthedocs.build/pep-0730/

@freakboy3742 freakboy3742 requested a review from a team as a code owner October 10, 2023 14:42
@AA-Turner
Copy link
Member

PEP 730 is yours

A

@AA-Turner AA-Turner changed the title Add first draft of an iOS support PEP. PEP 730: Adding iOS as a supported platform Oct 10, 2023
@AA-Turner AA-Turner added the new-pep A new draft PEP submitted for initial review label Oct 10, 2023
JelleZijlstra
JelleZijlstra reviewed Oct 10, 2023
View reviewed changes
Copy link
Member
8000
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some editorial comments.

@freakboy3742 freakboy3742 mentioned this pull request Oct 10, 2023
Merged
Yhg1s
Yhg1s reviewed Oct 10, 2023
View reviewed changes
freakboy3742 and others added 2 commits October 10, 2023 17:48
@freakboy3742 @Yhg1s
Grammar correction.
9d537a9 
Co-authored-by: T. Wouters <thomas@python.org>
@freakboy3742
Merge branch 'main' into iOS-support
65f8c1a
hugovk
hugovk reviewed Oct 10, 2023
View reviewed changes
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little nits.

hugovk
hugovk reviewed Oct 10, 2023
View reviewed changes
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more little nits. Overall looks good!

freakboy3742 and others added 2 commits October 11, 2023 08:59
@freakboy3742 @hugovk
Correct word wrap line length, and apply various edits picked up in c…
a32d0ae 
…ode review.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@freakboy3742
Add a note about being embedded only.
9335024
hugovk
hugovk approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@freakboy3742 @hugovk
Apply suggestions from code review
23fd044 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk hugovk merged commit 1418d8b into python:main Oct 11, 2023
@freakboy3742 freakboy3742 deleted the iOS-support branch October 11, 2023 09:03
@hugovk
Copy link
Member
hugovk commented Oct 11, 2023

This is now live at https://peps.python.org/pep-0730/ 📱🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yhg1s Yhg1s Yhg1s left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
new-pep A new draft PEP submitted for initial review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@freakboy3742 @AA-Turner @hugovk @JelleZijlstra @Yhg1s
0