fastparse: fix type checking on 3.8 #9693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got broken by python/typeshed#4740 It took me a little bit to figure out how this evaded all our CI, but it's because we type check with version 3.5 and mypyc only with 3.5 and 3.7. That is, we do not type check with 3.8 or later and so do not check against stdlib's AST types. mypyc wheels did break through, but I'm not sure anyone gets to see those. Maybe we should add a badge for them to the README. I only noticed this because I was trying to get mypy_primer to mypyc compile sometimes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken by python/typeshed#4740
It took me a little bit to figure out how this evaded all our CI, but
it's because we type check with version 3.5 and mypyc only with 3.5 and
3.7. That is, we do not type check with 3.8 or later and so do not check
against stdlib's AST types.
mypyc wheels did break though, but I'm not sure anyone really looks at
those till they need to. Maybe we should add a badge for them to
the README.
I only noticed this because I was trying to get mypy_primer to mypyc
compile sometimes.