fastparse: fix type checking on 3.8 (#9693)

hauntsaninja · web-flow · commit ff2ae7c1dce1 · 2020-11-03T07:40:43.000-08:00
This got broken by python/typeshed#4740 It took me a little bit to figure out how this evaded all our CI, but it's because we type check with version 3.5 and mypyc only with 3.5 and 3.7. That is, we do not type check with 3.8 or later and so do not check against stdlib's AST types. mypyc wheels did break through, but I'm not sure anyone gets to see those. Maybe we should add a badge for them to the README. I only noticed this because I was trying to get mypy_primer to mypyc compile sometimes. Co-authored-by: hauntsaninja <>
diff --git a/mypy/fastparse.py b/mypy/fastparse.py
@@ -676,11 +676,11 @@ def transform_args(self,
             names.append(args.vararg)
 
         # keyword-only arguments with defaults
-        for a, d in zip(args.kwonlyargs, args.kw_defaults):
+        for a, kd in zip(args.kwonlyargs, args.kw_defaults):
             new_args.append(self.make_argument(
                 a,
-                d,
-                ARG_NAMED if d is None else ARG_NAMED_OPT,
+                kd,
+                ARG_NAMED if kd is None else ARG_NAMED_OPT,
                 no_type_check))
             names.append(a)
 
