Fix 0.750 regression: union (non-)simplification should not affect inference #8077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Dec 4, 2019
mypy/constraints.py
Outdated
| @@ -108,6 +108,12 @@ def _infer_constraints(template: Type, actual: Type, | |||
| template = get_proper_type(template) | |||
| actual = get_proper_type(actual) | |||
|
|
|||
| # Type inference shouldn't be affected by whether union types have bee simplified. | |||
| @@ -3646,7 +3646,7 @@ def test_narrow_none() -> None: | |||
| a: Optional[int] | |||
| if int(): | |||
| a = narrow_none(a) | |||
| reveal_type(a) # N: Revealed type is 'Union[builtins.int, None]' | |||
| reveal_type(a) # N: Revealed type is 'builtins.int' | |||
There was a problem hiding this comment.
This is a nice improvement too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8051
The fix is as discussed in the issue. I didn't find a test case for the union
actual, but I think it makes sense to simplify it as well. Note: I add thepythonevaltest just as a regression test, if you think it is not worth it, I can remove it.