8000 Fix 0.750 regression: union (non-)simplification should not affect inference by ilevkivskyi · Pull Request #8077 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Fix 0.750 regression: union (non-)simplification should not affect inference #8077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 3 commits into from
Dec 4, 2019
Merged

Fix 0.750 regression: union (non-)simplification should not affect inference #8077

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
831e45c
Fix 0.750 regression: union (non-)simplification should nor affect in…
Dec 4, 2019
ec72ac6
Fix Python 3.5
Dec 4, 2019
396e74f
Fix typo
Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo
  • Loading branch information
Ivan Levkivskyi committed Dec 4, 2019
commit 396e74f375a5af9330aa0ce3498fb3d61b726b2f
2 changes: 1 addition & 1 deletion mypy/constraints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def _infer_constraints(template: Type, actual: Type,
template = get_proper_type(template)
actual = get_proper_type(actual)

# Type inference shouldn't be affected by whether union types have bee simplified.
# Type inference shouldn't be affected by whether union types have been simplified.
if isinstance(template, UnionType):
template = mypy.typeops.make_simplified_union(template.items)
if isinstance(actual, UnionType):
Expand Down
0