Clean up the traceback from the run mode
#5066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't start the server from inside a catch block, since that produces and ugly traceback if the server crashes.
ilevkivskyi
approved these changes
May 16, 2018
gvanrossum
approved these changes
May 17, 2018
|
I believe we don't have any tests for dmypy behavior. :-( We'd have to design a new test harness probably. |
|
Yeah, we would (and probably do) need a new harness. I expanded the fine grained testing to cover most of the tricky daemon logic, but there is still plenty that isn't. |
8886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't start the server from inside a catch block, since that produces
and ugly traceback if the server crashes.