Clean up the traceback from the run mode (#5066)

msullivan · web-flow · commit fae1f255bee7 · 2018-05-16T21:46:03.000-04:00
Don't start the server from inside a catch block, since that produces
and ugly traceback if the server crashes.
diff --git a/mypy/dmypy.py b/mypy/dmypy.py
@@ -212,9 +212,7 @@ def do_run(args: argparse.Namespace) -> None:
     since we don't want to duplicate mypy's huge list of flags.
     (The -- is only necessary if flags are specified.)
     """
-    try:
-        get_status()
-    except BadStatus as err:
+    if not is_running():
         # Bad or missing status file or dead process; good to start.
         start_server(args, allow_sources=True)
 
@@ -441,6 +439,15 @@ def read_status() -> Dict[str, object]:
     return data
 
 
+def is_running() -> bool:
+    """Check if the server is running cleanly"""
+    try:
+        get_status()
+    except BadStatus as err:
+        return False
+    return True
+
+
 # Run main().
 
 if __name__ == '__main__':
