8000 Extend special case for context-based typevar inference to typevar unions in return position by sterliakov · Pull Request #18976 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Extend special case for context-based typevar inference to typevar unions in return position #18976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 15, 2025
Merged

Extend special case for context-based typevar inference to typevar unions in return position #18976

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c4baf4e
Extend special-case for context-based typevar inference in return pos…
sterliakov Apr 26, 2025
8331546
Add missing get_proper_type
sterliakov Apr 26, 2025
7fcae0f
Fix a regression with `mapping.get(key, default_singleton)`
sterliakov Apr 26, 2025
43c097c
Switch to detecting *any* typevar in union in return position - `T | …
sterliakov Apr 26, 2025
e377115
Revert attempt to fix Mapping.get
sterliakov Apr 26, 2025
3f04d8e
Revert to `all()` - inferring for unions of typevar and something see…
sterliakov Apr 27, 2025
01cbfbc
Merge branch 'master' into bugfix/gh-17221-typevar-union-context
sterliakov May 6, 2025
f1e4dfc
Remove xfail test - fixed in previous PR
sterliakov May 6, 2025
8b5d140
Merge branch 'master' into bugfix/gh-17221-typevar-union-context
sterliakov May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch to detecting *any* typevar in union in return position - `T | … 
…str` is no less problematic
  • Loading branch information
@sterliakov
sterliakov committed Apr 26, 2025
commit 43c097c4e8ee7889ba256a0d161368cc0cf6ab61
8000 2 changes: 1 addition & 1 deletion mypy/checkexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2018,7 +2018,7 @@ def infer_function_type_arguments_using_context(
if (
isinstance(proper_ret, TypeVarType)
or isinstance(proper_ret, UnionType)
and all(isinstance(get_proper_type(u), TypeVarType) for u in proper_ret.items)
and any(isinstance(get_proper_type(u), TypeVarType) for u in proper_ret.items)
):
# Another special case: the return type is a type variable. If it's unrestricted,
# we could infer a too general type for the type variable if we use context,
Expand Down
Loading
0