8000 Extend special case for context-based typevar inference to typevar unions in return position by sterliakov · Pull Request #18976 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Extend special case for context-based typevar inference to typevar unions in return position #18976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 15, 2025
Merged

Extend special case for context-based typevar inference to typevar unions in return position #18976

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c4baf4e
Extend special-case for context-based typevar inference in return pos…
sterliakov Apr 26, 2025
8331546
Add missing get_proper_type
sterliakov Apr 26, 2025
7fcae0f
Fix a regression with `mapping.get(key, default_singleton)`
sterliakov Apr 26, 2025
43c097c
Switch to detecting *any* typevar in union in return position - `T | …
sterliakov Apr 26, 2025
e377115
Revert attempt to fix Mapping.get
sterliakov Apr 26, 2025
3f04d8e
Revert to `all()` - inferring for unions of typevar and something see…
sterliakov Apr 27, 2025
01cbfbc
Merge branch 'master' into bugfix/gh-17221-typevar-union-context
sterliakov May 6, 2025
f1e4dfc
Remove xfail test - fixed in previous PR
sterliakov May 6, 2025
8b5d140
Merge branch 'master' into bugfix/gh-17221-typevar-union-context
sterliakov May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove xfail test - fixed in previous PR
  • Loading branch information
@sterliakov
sterliakov committed May 6, 2025
commit f1e4dfc60f60ecd64d073dcc519939d5fea023e7
12 changes: 0 additions & 12 deletions test-data/unit/check-inference-context.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,15 +1510,3 @@ def mymin(
def check(paths: Iterable[str], key: Callable[[str], int]) -> Union[str, None]:
return mymin(paths, key=key, default=None)
[builtins fixtures/tuple.pyi]

[case testInferenceContextMappingGet-xfail]
from collections.abc import Mapping
from typing import TypeVar, Union

_T1 = TypeVar("_T1")

def check(mapping: Mapping[str, _T1]) -> None:
fail1 = mapping.get("", "")
fail2: Union[_T1, str] = mapping.get("", "")
[builtins fixtures/tuple.pyi]
[typing fixtures/typing-full.pyi]
0