8000 Sync typeshed by AlexWaygood · Pull Request #14902 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Sync typeshed #14902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Sync typeshed #14902

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0d32fd
Sync typeshed
AlexWaygood Mar 15, 2023
b3127a6
Remove use of LiteralString in builtins (#13743)
hauntsaninja Sep 26, 2022
1458891
Revert sum literal integer change (#13961)
hauntsaninja Oct 29, 2022
a8db537
Revert typeshed ctypes change (#14128)
hauntsaninja Nov 18, 2022
d1a82df
Revert use of `ParamSpec` for `functools.wraps`
AlexWaygood Mar 4, 2023
1ab6232
Fix tests
AlexWaygood Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading 8000
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests
  • Loading branch information
@AlexWaygood
AlexWaygood committed Mar 15, 2023
commit 1ab6232356c2292e7c0793b97aa590516c9e23d8
4 changes: 3 additions & 1 deletion test-data/unit/pythoneval.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,9 @@ def bin(f: IO[bytes]) -> None:
txt(sys.stdout)
bin(sys.stdout)
[out]
_program.py:5: error: Argument 1 to "write" of "IO" has incompatible type "bytes"; expected "str"
_program.py:5: error: No overload variant of "write" of "IO" matches argument type "bytes"
_program.py:5: note: Possible overload variants:
_program.py:5: note: def write(self, str, /) -> int
Comment on lines -271 to +273
Copy link
Member Author
@AlexWaygood AlexWaygood Mar 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in error message here is slightly unfortunate; the previous error message was better. It's due to a combination of python/typeshed#9861, which made IO.write an overloaded method, and #14882, which means that mypy now correctly deduces that only one overload applies in this specific situation.

_program.py:10: error: Argument 1 to "bin" has incompatible type "TextIO"; expected "IO[bytes]"

[case testBuiltinOpen]
Expand Down
0