10000 Sync typeshed by AlexWaygood · Pull Request #14902 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Sync typeshed #14902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Sync typeshed #14902

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0d32fd
Sync typeshed
AlexWaygood Mar 15, 2023
b3127a6
Remove use of LiteralString in builtins (#13743)
hauntsaninja Sep 26, 2022
1458891
Revert sum literal integer change (#13961)
hauntsaninja Oct 29, 2022
a8db537
Revert typeshed ctypes change (#14128)
hauntsaninja Nov 18, 2022
d1a82df
Revert use of `ParamSpec` for `functools.wraps`
AlexWaygood Mar 4, 2023
1ab6232
Fix tests
AlexWaygood Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading < 8000 /div>
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert sum literal integer change (#13961) 
This is allegedly causing large performance problems, see 13821

typeshed/8231 had zero hits on mypy_primer, so it's not the worst thing
to undo. Patching this in typeshed also feels weird, since there's a
more general soundness issue. If a typevar has a bound or constraint, we
might not want to solve it to a Literal.

If we can confirm the performance regression or fix the unsoundness
within mypy, I might pursue upstreaming this in typeshed.

(Reminder: add this to the sync_typeshed script once merged)
  • Loading branch information
@hauntsaninja @AlexWaygood
hauntsaninja authored and AlexWaygood committed Mar 15, 2023
commit 14588918873e3579487ebf2fe154164ee848a8b5
4 changes: 2 additions & 2 deletions mypy/typeshed/stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1638,11 +1638,11 @@ _SupportsSumNoDefaultT = TypeVar("_SupportsSumNoDefaultT", bound=_SupportsSumWit
# Instead, we special-case the most common examples of this: bool and literal integers.
if sys.version_info >= (3, 8):
@overload
def sum(__iterable: Iterable[bool | _LiteralInteger], start: int = 0) -> int: ... # type: ignore[misc]
def sum(__iterable: Iterable[bool], start: int = 0) -> int: ... # type: ignore[misc]

else:
@overload
def sum(__iterable: Iterable[bool | _LiteralInteger], __start: int = 0) -> int: ... # type: ignore[misc]
def sum(__iterable: Iterable[bool], __start: int = 0) -> int: ... # type: ignore[misc]

@overload
def sum(__iterable: Iterable[_SupportsSumNoDefaultT]) -> _SupportsSumNoDefaultT | Literal[0]: ...
Expand Down
0