8000 Add a (small) GDB tips section by smontanaro · Pull Request #977 · python/devguide · GitHub
[go: up one dir, main page]
Skip to content

10000 Add a (small) GDB tips section #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 4, 2022
Merged

Add a (small) GDB tips section #977

merged 9 commits into from
Nov 4, 2022

Conversation

smontanaro
Copy link
Contributor

This adds a GDB Tips section which describes two (I think) useful features when debugging the virtual machine, saving breakpoints to a file, and setting breakpoints at TARGET_<INST> labels.

hugovk
hugovk reviewed Oct 31, 2022
View reviewed changes
@smontanaro smontanaro marked this pull request as draft October 31, 2022 21:43
@smontanaro
Copy link
Contributor Author

Thanks for the suggestions @hugovk. I made a comment on one. Do you know how to edit it?

@hugovk
Copy link
Member
hugovk commented Oct 31, 2022

Thanks for the suggestions @hugovk. I made a comment on one. Do you know how to edit it?

Yep, done!

@smontanaro @hugovk
Apply suggestions from code review
db0c0c9 
Incorporate feedback from @hugovk to the PR.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@smontanaro
Copy link
Contributor Author

This is kind of related to this (by now a bit stale) PR.

@smontanaro smontanaro marked this pull request as ready for review November 1, 2022 04:11
erlend-aasland
erlend-aasland reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor
@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style nits and suggestions to make things slightly more succinct.

@smontanaro
Copy link
Contributor Author

Hmmm... The rest of the document seems to differ a bit from what these suggestions indicate. For example, sections about GDB 6 and 7 use "gdb" instead of "GDB". Should I just go through the file and make all the style suggestions in one go?

@smontanaro
Copy link
Contributor Author

Okay, I screwed up (again). I think I had accepted some earlier suggestions, but not incorporated them locally. Now when I try to push, I get:

% git push origin HEAD    
To github.com:smontanaro/devguide.git
 ! [rejected]        HEAD -> gdb-tips (fetch first)
error: failed to push some refs to 'github.com:smontanaro/devguide.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

How do I fix this?

@hauntsaninja
Copy link
Contributor

Maybe something like git pull origin --rebase $(git symbolic-ref --short HEAD), then git push origin HEAD

@erlend-aasland
Copy link
Contributor

Hmmm... The rest of the document seems to differ a bit from what these suggestions indicate. For example, sections about GDB 6 and 7 use "gdb" instead of "GDB". Should I just go through the file and make all the style suggestions in one go?

IMO it is better to apply such a change in a separate issue/PR. For this PR, just follow the guidelines. There are some inconsistencies, for example regarding the indent level, but larger parts of the affected file does follow the existing guidelines regarding indent level.

@smontanaro
Copy link
Contributor Author

Took a while, but I finally got things sync'd back up and accepted the various suggestions.

smontanaro and others added 2 commits November 2, 2022 13:28
@smontanaro @erlend-aasland
Apply suggestions from code review
f80fcd0 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@smontanaro
standardize other section headings
9183dd9
ezio-melotti
ezio-melotti reviewed Nov 3, 2022
View reviewed changes
@smontanaro @ezio-melotti
Update advanced-tools/gdb.rst
747eb55 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@erlend-aasland erlend-aasland merged commit 61218b4 into python:main Nov 4, 2022
@erlend-aasland
Copy link
Contributor

Thanks for this enhancement, Skip!

@smontanaro smontanaro deleted the gdb-tips branch November 4, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smontanaro @hugovk @hauntsaninja @erlend-aasland @ezio-melotti
0