-
-
Notifications
You must be signed in to change notification settings - Fork 862
Add a (small) GDB tips section
#977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the suggestions @hugovk. I made a comment on one. Do you know how to edit it? |
Yep, done! |
Incorporate feedback from @hugovk to the PR. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This is kind of related to this (by now a bit stale) PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some style nits and suggestions to make things slightly more succinct.
Hmmm... The rest of the document seems to differ a bit from what these suggestions indicate. For example, sections about GDB 6 and 7 use "gdb" instead of "GDB". Should I just go through the file and make all the style suggestions in one go? |
Okay, I screwed up (again). I think I had accepted some earlier suggestions, but not incorporated them locally. Now when I try to push, I get:
How do I fix this? |
Maybe something like |
IMO it is better to apply such a change in a separate issue/PR. For this PR, just follow the guidelines. There are some inconsistencies, for example regarding the indent level, but larger parts of the affected file does follow the existing guidelines regarding indent level. |
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Took a while, but I finally got things sync'd back up and accepted the various suggestions. |
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Thanks for this enhancement, Skip! |
This adds a GDB Tips section which describes two (I think) useful features when debugging the virtual machine, saving breakpoints to a file, and setting breakpoints at
TARGET_<INST>
labels.