8000 Add note about formatting-only PR by methane · Pull Request #635 · python/devguide · GitHub
[go: up one dir, main page]
Skip to content

Add note about formatting-only PR #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2020
Merged

Add note about formatting-only PR #635

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cbc56e
Add note about formatting-only PR
methane Oct 21, 2020
1b81157
Update pullrequest.rst
methane Oct 21, 2020
ce4696a
Update pullrequest.rst
willingc Oct 21, 2020
63df577
Update pullrequest.rst
willingc Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pullrequest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,11 @@ one or two discrepancies those can be fixed by the core developer who merges
your pull request. But if you have systematic deviations from the style guides
your pull request will be put on hold until you fix the formatting issues.

.. note::
Pull requests with only code formatting changes are usually rejected. On the other
hand, fixing typos and grammar errors in documents and docstrings are very
welcome.

Second, be aware of backwards-compatibility considerations. While the core
developer who eventually handles your pull request will make the final call on
whether something is acceptable, thinking about backwards-compatibility early
Expand Down
0