8000 Add note about formatting-only PR by methane · Pull Request #635 · python/devguide · GitHub
[go: up one dir, main page]
Skip to content

Add note about formatting-only PR #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2020
Merged

Add note about formatting-only PR #635

merged 4 commits into from
Oct 21, 2020

Conversation

methane
Copy link
Member
@methane methane commented Oct 21, 2020

No description provided.

corona10
corona10 approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member
@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

encukou
encukou approved these changes Oct 21, 2020
View reviewed changes
@methane @encukou
Update pullrequest.rst
1b81157 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
willingc
willingc approved these changes Oct 21, 2020
View reviewed changes
@willingc
Update pullrequest.rst
ce4696a
@willingc
Copy link
Collaborator

Love this addition @methane. Hope all is well. Merging as soon as all is green.

terryjreedy
terryjreedy previously requested changes Oct 21, 2020
View reviewed changes
@willingc @terryjreedy
Update pullrequest.rst
63df577 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@willingc willingc dismissed terryjreedy’s stale review October 21, 2020 22:26

Suggestions from @terryjreedy applied to PR

@willingc willingc merged commit e8021d1 into master Oct 21, 2020
@willingc willingc deleted the dont-format-only-pr branch October 21, 2020 22:26
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
@methane @encukou
@willingc @terryjreedy
Add note about formatting-only PR (python#635)
6c20cd9 
* Add note about formatting-only PR

* Update pullrequest.rst

Co-authored-by: Petr Viktorin <encukou@gmail.com>

* Update pullrequest.rst

* Update pullrequest.rst

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

@willingc willingc willingc approved these changes

@corona10 corona10 corona10 approved these changes

@terryjreedy terryjreedy terryjreedy left review comments

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@methane @willingc @encukou @corona10 @terryjreedy @the-knights-who-say-ni
0