8000 GH-96764: rewrite `asyncio.wait_for` to use `asyncio.timeout` by kumaraditya303 · Pull Request #98518 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-96764: rewrite asyncio.wait_for to use asyncio.timeout #98518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Feb 16, 2023
Merged

GH-96764: rewrite asyncio.wait_for to use asyncio.timeout #98518

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
487eac1
rewrite wait_for to use timeouts.timeout
kumaraditya303 Sep 12, 2022
794cb3a
skip one test
kumaraditya303 Oct 21, 2022
13ab78f
fix test as wait_for no longer creates
kumaraditya303 Oct 21, 2022
1eb0053
remove outdated tests
kumaraditya303 Oct 21, 2022
c704996
fix future test
kumaraditya303 Oct 22, 2022
bdaed9d
more tests
kumaraditya303 Oct 22, 2022
8ec6b37
fix whitespaces and comment
kumaraditya303 Oct 22, 2022
b711aa1
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 22, 2022
69c03b1
remove None special case
kumaraditya303 Oct 22, 2022
92df33b
Update Misc/NEWS.d/next/Library/2022-10-22-09-26-43.gh-issue-96764.Dh…
kumaraditya303 Oct 23, 2022
0290362
fix typo
kumaraditya303 Oct 24, 2022
4d3e9a3
remove a test
kumaraditya303 Oct 26, 2022
5fece55
fix comment
kumaraditya303 Nov 30, 2022
e7595a2
Merge branch 'main' of https://github.com/python/cpython into waitfor
kumaraditya303 Feb 12, 2023
9b0ef93
code review
kumaraditya303 Feb 12, 2023
c98ea70
add shield tests
kumaraditya303 Feb 12, 2023
8b54ce5
more comments
kumaraditya303 Feb 12, 2023
6d39219
whitespace
kumaraditya303 Feb 12, 2023
d7efdcb
typo
kumaraditya303 Feb 12, 2023
27cfdf9
formatting
kumaraditya303 Feb 12, 2023
979f07f
improve test
kumaraditya303 Feb 12, 2023
7a7082c
more comments
kumaraditya303 Feb 12, 2023
1239246
Update Lib/test/test_asyncio/test_waitfor.py
kumaraditya303 Feb 12, 2023
f0b5480
add back tasks.py changes, somehow got lost
kumaraditya303 Feb 12, 2023
355f2df
comments++
kumaraditya303 Feb 16, 2023
49d0ee4
fix typo
kumaraditya303 Feb 16, 2023
549b03f
remove wrong comment
kumaraditya303 Feb 16, 2023
56e6038
add code as explanantion
kumaraditya303 Feb 16, 2023
1a912f4
Update Lib/asyncio/tasks.py
kumaraditya303 Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Feb 16, 2023
commit 49d0ee4c8840781491f4daa42b1aceeb3feb8667
2 changes: 1 addition & 1 deletion Lib/test/test_asyncio/test_waitfor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ async def test_zero_timeout(self):
# `asyncio.shield` creates a new task which wraps the passed in
# awaitable and shields it from cancellation so with timeout=0
# the task returned by `asyncio.shield` aka shielded_task gets
# cancelled immediately and the task wrapped by is scheduled
# cancelled immediately and the task wrapped by it is scheduled
# to run.

async def coro():
Expand Down
0