-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
GH-96764: rewrite asyncio.wait_for
to use asyncio.timeout
#98518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
487eac1
rewrite wait_for to use timeouts.timeout
kumaraditya303 794cb3a
skip one test
kumaraditya303 13ab78f
fix test as wait_for no longer creates
kumaraditya303 1eb0053
remove outdated tests
kumaraditya303 c704996
fix future test
kumaraditya303 bdaed9d
more tests
kumaraditya303 8ec6b37
fix whitespaces and comment
kumaraditya303 b711aa1
📜🤖 Added by blurb_it.
blurb-it[bot] 69c03b1
remove None special case
kumaraditya303 92df33b
Update Misc/NEWS.d/next/Library/2022-10-22-09-26-43.gh-issue-96764.Dh…
kumaraditya303 0290362
fix typo
kumaraditya303 4d3e9a3
remove a test
kumaraditya303 5fece55
fix comment
kumaraditya303 e7595a2
Merge branch 'main' of https://github.com/python/cpython into waitfor
kumaraditya303 9b0ef93
code review
kumaraditya303 c98ea70
add shield tests
kumaraditya303 8b54ce5
more comments
kumaraditya303 6d39219
whitespace
kumaraditya303 d7efdcb
typo
kumaraditya303 27cfdf9
formatting
kumaraditya303 979f07f
improve test
kumaraditya303 7a7082c
more comments
kumaraditya303 1239246
Update Lib/test/test_asyncio/test_waitfor.py
kumaraditya303 f0b5480
add back tasks.py changes, somehow got lost
kumaraditya303 355f2df
comments++
kumaraditya303 49d0ee4
fix typo
kumaraditya303 549b03f
remove wrong comment
kumaraditya303 56e6038
add code as explanantion
kumaraditya303 1a912f4
Update Lib/asyncio/tasks.py
kumaraditya303 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix test as wait_for no longer creates
a new task so no sleep is required
- Loading branch information
commit 13ab78fb85bcb4f570a9729a9ee76cd7786ebab7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.