GH-96764: rewrite asyncio.wait_for to use asyncio.timeout
#98518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45d0725 to
6c944d9
Compare
|
This is more of a POC at this point. I think it is worth changing cc @gvanrossum |
gvanrossum
reviewed
Oct 21, 2022
gvanrossum
reviewed
Oct 21, 2022
gvanrossum
reviewed
Oct 22, 2022
Misc/NEWS.d/next/Library/2022-10-22-09-26-43.gh-issue-96764.Dh9Y5L.rst
Outdated
Show resolved
Hide resolved
gvanrossum
reviewed
Oct 22, 2022
|
I had hoped to first merge one of the alternatives that can be backported to 3.10, so we can declare this fixed in 3.10. Then we would merge this one on top of that, but only in 3.11 and main. But we could also just do a custom fix for 3.10 based on one of @twisteroidambassador's PRs. (I wish you had linked this PR to the same issue rather than creating a new issue, since it's all related.) |
|
In particular, @twisteroidambassador has this PR: #98607 |
akulakov
reviewed
Nov 3, 2022
a new task so no sleep is required
mdonoughe
pushed a commit
to gurumitts/pylutron-caseta
that referenced
this pull request
Mar 11, 2023
* Switch to using asyncio.timeout instead of asyncio.wait_for `asyncio.wait_for` creates a task whereas `asyncio.timeout` avoids doing this. Fallback to using `async_timeout` when the python version is too old (<3.11) `asyncio.timeout` will become the underlying implementation for `async.wait_for` in cpython 3.12 python/cpython#98518
aaugustin
pushed a commit
to python-websockets/websockets
that referenced
this pull request
Apr 2, 2023
asyncio.wait_for creates a task whereas asyncio.timeout doesn't. Fallback to a vendored version of async_timeout on Python < 3.11. async.timeout will become the underlying implementation for async.wait_for in Python 3.12: python/cpython#98518
aaugustin
pushed a commit
to bdraco/websockets
that referenced
this pull request
Apr 2, 2023
asyncio.wait_for creates a task whereas asyncio.timeout doesn't. Fallback to a vendored version of async_timeout on Python < 3.11. async.timeout will become the underlying implementation for async.wait_for in Python 3.12: python/cpython#98518
aaugustin
pushed a commit
to python-websockets/websockets
that referenced
this pull request
Apr 2, 2023
asyncio.wait_for creates a task whereas asyncio.timeout doesn't. Fallback to a vendored version of async_timeout on Python < 3.11. async.timeout will become the underlying implementation for async.wait_for in Python 3.12: python/cpython#98518
This was referenced Apr 9, 2023
bdraco
added a commit
to bdraco/aiolifx
that referenced
this pull request
Apr 10, 2023
`asyncio.wait_for` creates another tasks which leads to some race conditions in cancelation and a performance hit cpython 3.12 will change the underlying implementation of `asyncio.wait_for` to use `asyncio.wait` but that is still a long way off for many people: python/cpython#98518
This was referenced Apr 10, 2023
7 tasks
bdraco
added a commit
to bdraco/python-kasa
that referenced
this pull request
Jul 21, 2023
Fallback to using async_timeout on older python asyncio.wait_for has some underlying problems that are only fixed in cpython 3.12. See python/cpython#98518
bdraco
added a commit
to bdraco/python-kasa
that referenced
this pull request
Jul 21, 2023
Fallback to using async_timeout on older python asyncio.wait_for has some underlying problems that are only fixed in cpython 3.12. See python/cpython#98518
bdraco
added a commit
to bdraco/python-kasa
that referenced
this pull request
Jul 21, 2023
Fallback to using async_timeout on older python asyncio.wait_for has some underlying problems that are only fixed in cpython 3.12. See python/cpython#98518
bdraco
added a commit
to bdraco/python-kasa
that referenced
this pull request
Jul 21, 2023
Fallback to using async_timeout on older python asyncio.wait_for has some underlying problems that are only fixed in cpython 3.12. See python/cpython#98518
rytilahti
pushed a commit
to python-kasa/python-kasa
that referen
67E6
ced
this pull request
Jul 21, 2023
asyncio.wait_for has some underlying problems that are only fixed in cpython 3.12. Use async_timeout instead until the minimum supported version is 3.11+ and it can be replaced with asyncio.timeout See python/cpython#98518
bdraco
added a commit
to bdraco/ha-HAP-python
that referenced
this pull request
Jul 23, 2023
async_timeout does not suffer from the same race problems as asyncio.wait_for see python/cpython#98518 for more details
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Aug 4, 2023
wasted some time because asyncio.wait_for() was suppressing cancellations. [0][1][2] deja vu... [3] Looks like this is finally getting fixed in cpython 3.12 [4] So far away... In attempt to avoid encountering this again, let's try using asyncio.timeout in 3.11, which is how upstream reimplemented wait_for in 3.12 [4], and aiorpcx.timeout_after in 3.8-3.10. [0] python/cpython#86296 [1] https://bugs.python.org/issue42130 [2] https://bugs.python.org/issue45098 [3] kyuupichan/aiorpcX#44 [4] python/cpython#98518
SomberNight
added a commit
to spesmilo/electrum
that referenced
this pull request
Aug 4, 2023
wasted some time because asyncio.wait_for() was suppressing cancellations. [0][1][2] deja vu... [3] Looks like this is finally getting fixed in cpython 3.12 [4] So far away... In attempt to avoid encountering this again, let's try using asyncio.timeout in 3.11, which is how upstream reimplemented wait_for in 3.12 [4], and aiorpcx.timeout_after in 3.8-3.10. [0] python/cpython#86296 [1] https://bugs.python.org/issue42130 [2] https://bugs.python.org/issue45098 [3] kyuupichan/aiorpcX#44 [4] python/cpython#98518
bdraco
added a commit
to bdraco/python-androidtv
that referenced
this pull request
Aug 31, 2023
`asyncio.wait_for` creates another tasks which leads to some race conditions in cancelation and a performance hit cpython 3.12 will change the underlying implementation of `asyncio.wait_for` to use `asyncio.wait` but that is still a long way off for many people: python/cpython#98518
JeffLIrion
pushed a commit
to JeffLIrion/python-androidtv
that referenced
this pull request
Sep 1, 2023
* Switch usage of asyncio.wait_for to async_timeout `asyncio.wait_for` creates another tasks which leads to some race conditions in cancelation and a performance hit cpython 3.12 will change the underlying implementation of `asyncio.wait_for` to use `asyncio.wait` but that is still a long way off for many people: python/cpython#98518 * adjust ci
32 tasks
20 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
asyncio.wait_forto useasyncio.timeoutas its underlying implementation. It simplifies the code and makes it easy to understand the cancellation semantics as bothasyncio.timeoutandasyncio.wait_forbehaves similarly.Fixes #86296
Fixes #81839
Fixes #96764
asyncio.wait_forusingasyncio.timeout#96764