Use asyncio.timeout instead of asyncio.wait_for
#1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## dev #1187 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 48 48
Lines 7857 7863 +6
=======================================
+ Hits 7820 7826 +6
Misses 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
bdraco
added a commit
to bdraco/zigpy-deconz
that referenced
this pull request
Sep 4, 2023
puddly
added a commit
to zigpy/zigpy-deconz
that referenced
this pull request
Sep 11, 2023
* Switch asyncio.wait_for to asyncio_timeout see zigpy/zigpy#1187 * Directly import from the `async_timeout` package --------- Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cancellation semantics of
asyncio.wait_forare probably the root cause of the task cancellation bug (#809). zigpy-znp has always usedasyncio.timeoutinternally without any problems so we may as well migrate zigpy as well. Plus, the context manager syntax is usually clearer.python/cpython#98518