8000 GH-98388: Add tests for happy eyeballs and its internal workings by twisteroidambassador · Pull Request #98389 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-98388: Add tests for happy eyeballs and its internal workings #98389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+195 −0
Open

GH-98388: Add tests for happy eyeballs and its internal workings #98389

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d8b4492
Add tests for happy eyeballs and its internal workings.
twisteroidambassador Oct 18, 2022
34a8f6f
Correct typo in filename.
twisteroidambassador Oct 18, 2022
c0e179e
Improve readability for _interleave_addrinfos tests.
twisteroidambassador Oct 18, 2022
8270e69
Rename _interleave_addrinfos tests to match the method being tested.
twisteroidambassador Oct 18, 2022
afb6abf
Made test_simultaneous_success_fail fail more consistently (I hope).
twisteroidambassador Oct 18, 2022
513f7f9
Replace `wait_for` with `wait`.
twisteroidambassador Oct 19, 2022
079eec8
Delete staggered.py
arhadthedev Apr 26, 2023
ec144fb
Merge branch 'main' into happy_eyeballs_checkup
arhadthedev Apr 26, 2023
5ec7d65
Restore staggered.py from `main` branch
arhadthedev Apr 26, 2023
4e9f06a
Address patchcheck report
arhadthedev Apr 26, 2023
62387d6
Merge branch 'main' into happy_eyeballs_checkup
gvanrossum May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Made test_simultaneous_success_fail fail more consistently (I hope).
  • Loading branch information
@twisteroidambassador
twisteroidambassador committed Oct 18, 2022
commit afb6abfae9e1510ec65cc5ee493f7d0893675bfa
11 changes: 7 additions & 4 deletions Lib/test/test_asyncio/test_staggered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,17 @@ async def test_second_fail(self):
async def test_simultaneous_success_fail(self):
# There's a potential race condition here:
# https://github.com/python/cpython/issues/86296
for _ in range(50):
# As with any race condition, it can be difficult to reproduce.
# This test may not fail every time.
for i in range(201):
time_unit = 0.0001 * i
winner_result, winner_idx, exceptions = await staggered_race(
(
self.get_waiting_coroutine_factory(0, 0.1, True),
self.get_waiting_coroutine_factory(1, 0.05, False),
self.get_waiting_coroutine_factory(0, time_unit*2, True),
self.get_waiting_coroutine_factory(1, time_unit, False),
self.get_waiting_coroutine_factory(2, 0.05, True)
),
0.05,
time_unit,
)
self.assertEqual(winner_result, 0)
self.assertEqual(winner_idx, 0)
Expand Down
0