gh-72073: Add Windows case in pathlib.rename #93002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barneygale
approved these changes
May 20, 2022
brettcannon
approved these changes
May 20, 2022
|
Thanks @slateny for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2022
pythonGH-72073 https://docs.python.org/3.12/library/pathlib.htmlGH-pathlib.Path.rename (cherry picked from commit f51ed04) Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
|
GH-93028 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2022
pythonGH-72073 https://docs.python.org/3.12/library/pathlib.htmlGH-pathlib.Path.rename (cherry picked from commit f51ed04) Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
|
GH-93029 is a backport of this pull request to the 3.10 branch. |
|
Unfortunately there's a mistake in the PR: the directive should have been |
|
#93030 fixes the directive mistake. |
miss-islington
added a commit
that referenced
this pull request
May 20, 2022
) GH-72073 https://docs.python.org/3.12/library/pathlib.htmlGH-pathlib.Path.rename (cherry picked from commit f51ed04) Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com> Automerge-Triggered-By: GH:brettcannon
miss-islington
added a commit
that referenced
this pull request
May 20, 2022
) GH-72073 https://docs.python.org/3.12/library/pathlib.htmlGH-pathlib.Path.rename (cherry picked from commit f51ed04) Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com> Automerge-Triggered-By: GH:brettcannon
|
Ah good catch, interesting that even with |
rhettinger
pushed a commit
to rhettinger/cpython
that referenced
this pull request
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#72073
https://docs.python.org/3.12/library/pathlib.html#pathlib.Path.rename
Automerge-Triggered-By: GH:brettcannon