8000 [3.11] gh-72073: Add Windows case in pathlib.rename (GH-93002) by miss-islington · Pull Request #93028 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.11] gh-72073: A 8000 dd Windows case in pathlib.rename (GH-93002) #93028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2022
Merged

[3.11] gh-72073: Add Windows case in pathlib.rename (GH-93002) #93028

merged 2 commits into from
May 20, 2022

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented May 20, 2022 •
edited
Loading

GH-72073

https://docs.python.org/3.12/library/pathlib.htmlGH-pathlib.Path.rename
(cherry picked from commit f51ed04)

Co-authored-by: Stanley 46876382+slateny@users.noreply.github.com

Automerge-Triggered-By: GH:brettcannon

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 20, 2022
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir awaiting review labels May 20, 2022
brettcannon
brettcannon requested changes May 20, 2022
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Head branch was modified. Review and try the merge again..
8000

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 61dfe37 into python:3.11 May 20, 2022
@miss-islington miss-islington deleted the backport-f51ed04-3.11 branch May 20, 2022 22:42
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @bedevere-bot @brettcannon @slateny
0