8000 gh-81488: Add recursive wording for issubclass by slateny · Pull Request #92087 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-81488: Add recursive wording for issubclass #92087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2022
Merged

gh-81488: Add recursive wording for issubclass #92087

merged 2 commits into from
May 1, 2022

Conversation

slateny
Copy link
Contributor
@slateny slateny commented Apr 30, 2022

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 30, 2022
@AlexWaygood
Copy link
Member

This probably can't be cleanly backported to 3.9 due to the reference to Union types. Are you interested in doing a manual backport to 3.9 (if it's merged), or shall we leave 3.9?

AlexWaygood
AlexWaygood approved these changes Apr 30, 2022
View reviewed changes
Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no idea what's going on with the CI failures, but this LGTM

@slateny
Copy link
Contributor Author
slateny commented Apr 30, 2022 •
edited
Loading

Sure, I can do a manual backport, and not too sure about the CI error either CI errors are related to a merged whatsnew entry, left a comment in that PR

@JelleZijlstra JelleZijlstra self-assigned this Apr 30, 2022
@JelleZijlstra JelleZijlstra merged commit 1066ecb into python:main May 1, 2022
@miss-islington
Copy link
Contributor

Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92101 is a backport of this pull request to the 3.10 branch.

@miss-islington
Copy link
Contributor

Sorry, @slateny and @JelleZijlstra, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1066ecb97042b8e89de554e6f9dc2e3d634208c0 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 1, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 1, 2022
@slateny @miss-islington
pythongh-81488: Add recursive wording for issubclass docs (pythonGH-9…
011784b 
…2087)

(cherry picked from commit 1066ecb)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
@JelleZijlstra
Copy link
Member

@slateny leaving the 3.9 backport to you. Thanks for your many docs improvements!

miss-islington added a commit that referenced this pull request May 1, 2022
@miss-islington @slateny
gh-81488: Add recursive wording for issubclass docs (GH-92087)
a48d31f 
(cherry picked from commit 1066ecb)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
slateny added a commit to slateny/cpython that referenced this pull request May 2, 2022
@slateny
[3.9] pythongh-81488: Add recursive wording for issubclass docs (pyth…
d03a04e 
…onGH-92087).

(cherry picked from commit 1066ecb)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
@bedevere-bot
Copy link

GH-92131 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 2, 2022
JelleZijlstra pushed a commit that referenced this pull request May 2, 2022
@slateny
[3.9] gh-81488: Add recursive wording for issubclass docs (GH-92087) (#…
28cd98f 
…92131)

(cherry picked from commit 1066ecb)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
@slateny slateny deleted the s/functions branch May 4, 2022 01:48
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@slateny @hello-adam
[3.9] pythongh-81488: Add recursive wording for issubclass docs (pyth…
454154a 
…onGH-92087) (python#92131)

(cherry picked from commit 1066ecb)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
@slateny slateny mentioned this pull request Jun 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@slateny @AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra
0