8000 bpo-32610: Fix asyncio.all_tasks() to return only pending tasks. by 1st1 · Pull Request #7174 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-32610: Fix asyncio.all_tasks() to return only pending tasks. #7174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2018
Merged

bpo-32610: Fix asyncio.all_tasks() to return only pending tasks. #7174

merged 2 commits into from
May 28, 2018

Conversation

1st1
Copy link
Member
@1st1 1st1 commented May 28, 2018 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from asvetlov as a code owner May 28, 2018 20:41
asvetlov
asvetlov reviewed May 28, 2018
View reviewed changes
Copy link
Contributor
@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation should reflect the difference

Lib/asyncio/tasks.py Outdated
@@ -33,6 +33,16 @@ def current_task(loop=None):

def all_tasks(loop=None):
"""Return a set of all tasks for the loop."""
if loop is None:
loop = events.get_event_loop()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_running_loop() maybe?
If all_tasks() is not the same as Task.all_tasks() anymore...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go for running, yes; it was my original request. Let me update the PR.

@1st1
Copy link
Member Author
1st1 commented May 28, 2018

@asvetlov updated

@1st1 1st1 merged commit 416c1eb into python:master May 28, 2018
@miss-islington
8000 Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@1st1 1st1 deleted the fixall branch May 28, 2018 21:54
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2018
@1st1 @miss-islington
bpo-32610: Fix asyncio.all_tasks() to return only pending tasks. (pyt…
8286253 
…honGH-7174)

(cherry picked from commit 416c1eb)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot
Copy link

GH-7181 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 29, 2018
@miss-islington @1st1
bpo-32610: Fix asyncio.all_tasks() to return only pending tasks. (GH-…
ddc613f 
…7174)

(cherry picked from commit 416c1eb)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1st1 @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni
0