Skip finished tasks when checking for async leaked tasks #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathowl
approved these changes
Nov 9, 2020
|
Thanks for the PR @kchatzii |
fornellas
reviewed
Nov 9, 2020
| @@ -72,6 +72,10 @@ def asyncio_run(coro): | |||
| get_all_tasks = asyncio.all_tasks | |||
|
|
|||
|
|
|||
| def get_running_tasks(): | |||
There was a problem hiding this comment.
s/get_running_tasks/get_not_done_tasks/g.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Updated leaked tasks checking to skip finished coroutines, in order to avoid incorrect failures when tasks have been completed
Why:
With Python versions that doesnt include this fix (python/cpython#7174), Testslide will raise a LeftOverActiveTasks exception even if all coroutines have been completed successfully.
Example:
<Task finished coro=<TestAsyncRun.test_catches_leaked_tasks.<locals>.dummy_async_func() done, defined at *> result=None created at *>Although the task is done, Testslide will fail.
This PR skips finished tasks from the async leak testing
How:
Checklist: