8000 [3.7] bpo-32896: Fix error when subclassing a dataclass with a field that uses a default_factory (GH-6170) by miss-islington · Pull Request #6171 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
[3.7] bpo-32896: Fix error when subclassing a dataclass with a field that uses a default_factory (GH-6170) #6171
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2018
Merged

[3.7] bpo-32896: Fix error when subclassing a dataclass with a field that uses a default_factory (GH-6170) #6171

merged 1 commit into from
Mar 21, 2018

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Mar 21, 2018 •
edited by bedevere-bot
Loading

Fix the way that new annotations in a class are detected.
(cherry picked from commit 8f6eccd)

Co-authored-by: Eric V. Smith ericvsmith@users.noreply.github.com

https://bugs.python.org/issue32896

@ericvsmith @miss-islington
bpo-32896: Fix error when subclassing a dataclass with a field that 8000 u…
7a2075a 
…ses a default_factory (pythonGH-6170)

Fix the way that new annotations in a class are detected.
(cherry picked from commit 8f6eccd)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this pull request Mar 21, 2018
Merged
@miss-islington
Copy link
Contributor Author

@ericvsmith: Backport status check is done, and it's a success ✅ .

@ericvsmith ericvsmith merged commit 22136c9 into python:3.7 Mar 21, 2018
@miss-islington
Copy link
Contributor Author

Thanks, @ericvsmith!

@miss-islington miss-islington deleted the backport-8f6eccd-3.7 branch March 21, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @ericvsmith @the-knights-who-say-ni @bedevere-bot
0