8000 bpo-32896: Fix error when subclassing a dataclass with a field that uses a default_factory by ericvsmith · Pull Request #6170 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-32896: Fix error when subclassing a dataclass with a field that uses a default_factory #6170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 21, 2018
Merged

bpo-32896: Fix error when subclassing a dataclass with a field that uses a default_factory #6170

merged 7 commits into from
Mar 21, 2018

Conversation

ericvsmith
Copy link
Member
@ericvsmith ericvsmith commented Mar 21, 2018 •
edited by bedevere-bot
Loading

@ericvsmith ericvsmith merged commit 8f6eccd into python:master Mar 21, 2018
@miss-islington
Copy link
Contributor

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@ericvsmith ericvsmith deleted the bpo-32896-default-factory-default-derived branch March 21, 2018 02:00
@bedevere-bot
Copy link

GH-6171 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2018
@ericvsmith @miss-islington
bpo-32896: Fix error when subclassing a dataclass with a field that u…
7a2075a 
…ses a default_factory (pythonGH-6170)

Fix the way that new annotations in a class are detected.
(cherry picked from commit 8f6eccd)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
ericvsmith added a commit that referenced this pull request Mar 21, 2018
@miss-islington @ericvsmith
bpo-32896: Fix error when subclassing a dataclass with a field that u…
22136c9 
…ses a default_factory (GH-6170) (GH-6171)

Fix the way that new annotations in a class are detected.
(cherry picked from commit 8f6eccd)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
@ericvsmith @jo2y
bpo-32896: Fix error when subclassing a dataclass with a field that u…
9e1ffee 
…ses a default_factory (pythonGH-6170)

Fix the way that new annotations in a class are detected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericvsmith @miss-islington @bedevere-bot @the-knights-who-say-ni
0