python · vstinner · Nov 7, 2017 · Oct 11, 2017 · Oct 11, 2017 · Oct 12, 2017
diff --git a/Lib/sqlite3/test/regression.py b/Lib/sqlite3/test/regression.py
@@ -188,6 +188,7 @@ def __init__(self, con):
         cur = Cursor(con)
         with self.assertRaises(sqlite.ProgrammingError):
             cur.execute("select 4+5").fetchall()
+        self.assertRaises(sqlite.ProgrammingError, cur.close)
 
     def CheckStrSubclass(self):
         """

diff --git a/Misc/NEWS.d/next/Library/2017-10-11-22-18-04.bpo-31764.EMyIkK.rst b/Misc/NEWS.d/next/Library/2017-10-11-22-18-04.bpo-31764.EMyIkK.rst
@@ -0,0 +1,2 @@
+Prevent a crash in `sqlite3.Cursor.close()` in case the `Cursor` object is
+uninitialized. Patch by Oren Milman.
diff --git a/Modules/_sqlite/cursor.c b/Modules/_sqlite/cursor.c
@@ -890,6 +890,11 @@ PyObject* pysqlite_noop(pysqlite_Connection* self, PyObject* args)
 
 PyObject* pysqlite_cursor_close(pysqlite_Cursor* self, PyObject* args)
 {
+    if (self->connection == NULL) {
+        PyErr_SetString(pysqlite_ProgrammingError,
+                        "Base Cursor.__init__ not called.");
+        return NULL;
+    }
     if (!pysqlite_check_thread(self->connection) || !pysqlite_check_connection(self->connection)) {
         return NULL;
     }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Prevent a crash in `sqlite3.Cursor.close()` in case the `Cursor` object is
Copy link Member berkerpeksag Oct 12, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Please use double backticks (``). I tried to explain why single backticks shouldn't be used at #3925 (comment) Copy link Contributor Author orenmn Oct 12, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I am not familiar with Sphinx, but i trust you are :) So maybe https://devguide.python.org/committing/#what-s-new-and-news-entries should also recommend double backticks? Copy link Member berkerpeksag Oct 12, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Yeah, I wasn't aware of that example in the devguide. I will update it, thanks!
		uninitialized. Patch by Oren Milman.