8000 bpo-31764: Prevent a crash in sqlite3.Cursor.close() in case the Cursor object is uninitialized by orenmn · Pull Request #3958 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-31764: Prevent a crash in sqlite3.Cursor.close() in case the Cursor object is uninitialized #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2017
Merged

bpo-31764: Prevent a crash in sqlite3.Cursor.close() in case the Cursor object is uninitialized #3958

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3bcda3
init commit
orenmn Oct 11, 2017
c07d198
improve the NEWS.d item
orenmn Oct 11, 2017
25ff4f3
improve the test and the NEWS.d item, and make a style change in the …
orenmn Oct 12, 2017
7e0cc4c
don't change the old test in CheckCursorConstructorCallCheck
orenmn Oct 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve the NEWS.d item
  • Loading branch information
@orenmn
orenmn committed Oct 11, 2017
commit c07d198b2c2144265822b5e3bbd0b0bcc8aece49
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2017-10-11-22-18-04.bpo-31764.EMyIkK.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Prevent a crash in `sqlite3.Cursor.close()` in case the Cursor object is
Prevent a crash in `sqlite3.Cursor.close()` in case the `Cursor` object is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use double backticks (``). I tried to explain why single backticks shouldn't be used at #3925 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with Sphinx, but i trust you are :)
So maybe https://devguide.python.org/committing/#what-s-new-and-news-entries should also recommend double backticks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wasn't aware of that example in the devguide. I will update it, thanks!

uninitialized. Patch by Oren Milman.
0