8000 bpo-46841: Inline cache for `BINARY_SUBSCR`. by markshannon · Pull Request #31618 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46841: Inline cache for BINARY_SUBSCR. #31618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 1, 2022
Merged

bpo-46841: Inline cache for BINARY_SUBSCR. #31618

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
465f0c0
Use inline cache for BINARY_SUBSCR. Work in progress.
markshannon Feb 28, 2022
8381b7f
Merge branch 'main' into inline-cache-binary-subscr
markshannon Feb 28, 2022
a9f7043
Finish inlining cache for .
markshannon Feb 28, 2022
a330574
Tidy up
markshannon Feb 28, 2022
e4b0ba0
Address review comments.
markshannon Mar 1, 2022
05787b3
Remove per-code-object-cache and add small per-heap-type cache.
markshannon Mar 1, 2022
956ed1e
Remove unused parameter.
markshannon Mar 1, 2022
0e282f3
Remove unused code.
markshannon Mar 1, 2022
d0c9077
Merge branch 'main' into inline-cache-binary-subscr
markshannon Mar 1, 2022
f667ddb
Clarify comments.
markshannon Mar 1, 2022
2271337
Fix typo.
markshannon Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into inline-cache-binary-subscr
  • Loading branch information
@markshannon
markshannon committed Mar 1, 2022
commit d0c90777b68813e47f1c4e0f6db741bcda665d23
7 changes: 7 additions & 0 deletions Include/internal/pycore_code.h
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@ typedef struct {
#define INLINE_CACHE_ENTRIES_UNPACK_SEQUENCE \
CACHE_ENTRIES(_PyUnpackSequenceCache)
typedef struct {
_Py_CODEUNIT counter;
_Py_CODEUNIT mask;
} _PyCompareOpCache;

#define INLINE_CACHE_ENTRIES_COMPARE_OP CACHE_ENTRIES(_PyCompareOpCache)

typedef struct {
_Py_CODEUNIT counter;
_Py_CODEUNIT type_version;
Expand Down
2 changes: 1 addition & 1 deletion Lib/importlib/_bootstrap_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ def _write_atomic(path, data, mode=0o666):
# Python 3.11a5 3480 (New CALL opcodes, second iteration)
# Python 3.11a5 3481 (Use inline cache for BINARY_OP)
# Python 3.11a5 3482 (Use inline caching for UNPACK_SEQUENCE and LOAD_GLOBAL)
# Python 3.11a5 3483 (Use inline caching for BINARY_SUBSCR)
# Python 3.11a5 3483 (Use inline caching for COMPARE_OP and BINARY_SUBSCR)

# Python 3.12 will start with magic number 3500

Expand Down
2 changes: 1 addition & 1 deletion Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5610,7 +5610,7 @@ MISS_WITH_CACHE(LOAD_METHOD)
MISS_WITH_CACHE(PRECALL)
MISS_WITH_CACHE(CALL)
MISS_WITH_INLINE_CACHE(BINARY_OP)
MISS_WITH_CACHE(COMPARE_OP)
MISS_WITH_INLINE_CACHE(COMPARE_OP)
MISS_WITH_INLINE_CACHE(BINARY_SUBSCR)
MISS_WITH_INLINE_CACHE(UNPACK_SEQUENCE)
MISS_WITH_OPARG_COUNTER(STORE_SUBSCR)
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
0